fix(dev-portal): align stacking with app portal - #5193
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: c0a3772 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Coverage Report
File CoverageNo changed files found. |
chdefrene
changed the base branch from
main
to
chdefrene-rollout-context-selector-toplayer
July 31, 2026 08:53
chdefrene
changed the base branch from
chdefrene-rollout-context-selector-toplayer
to
main
July 31, 2026 08:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
Hosted applications in the dev portal should use the same overlay layering contract as
app-portal. Without that contract, fixed overlays can obscure portal chrome and side-sheet content can begin underneath the 48px header.What is the current behavior?
The dev portal header and hosted-app region do not establish the same stacking levels as
app-portal. Hosted side sheets also fall back to the viewport origin because their app scope does not inherit the portal header offset.What is the new behavior?
The header renders in stacking layer 2 and the positioned hosted-app region renders in stacking layer 1. The app region scopes a hardcoded 48px header offset so side sheets begin below the header and use the remaining viewport height, while full-viewport scrims remain behind portal chrome.
What is the intended behavior or invariant?
Portal chrome must remain above overlays created by hosted applications. Hosted overlays must inherit the dev portal's 48px header boundary without introducing a global CSS variable.
Does this PR introduce a breaking change?
No.
Impact assessment:
app-portaloverlay placement and stacking.@equinor/fusion-framework-dev-portalconsumers.Review guidance:
Compare the
HeadandMainstacking values withapp-portal's header (z-index: 2) and app mount (z-index: 1). In a hosted app, open a side sheet and verify its top is 48px, its bottom reaches the viewport edge, and its scrim does not cover the portal header.Additional context
A patch changeset is included. Local
app-adminverification confirmed the side sheet renders from 48px to the viewport bottom and the scrim remains below the header stacking layer.Validation:
pnpm testpassed.pnpm buildpassed.pnpm -w checkreaches one pre-existing formatting error in unchangedpackages/linting/rules/src/require-property-tsdoc/index.ts; that file matchesorigin/main.Related issues
None.
Checklist