chore: fix fusion-lint warnings in module-app and module-navigation - #5343
Merged
Conversation
🦋 Changeset detectedLatest commit: 6f6fc2f The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
🚧 chore
- schemas.ts: mark FrameworkOptionsSchema as intentionally co-located, matching the existing suppression convention for the other schemas in this file (single-export-per-file). - NavigationProvider.ts: add intent comments to the for/if/while blocks in normalizePathname and stripTrailingSlashes (require-intent-comment/flow).
actions/checkout pins ref to the PR head SHA, so it only fetches that
commit's history and never creates a local/remote-tracking ref for main.
turbo's --affected then fails to resolve main as a merge-base ('ambiguous
argument main'), silently falling back to building every package instead
of just the affected ones. Fetch origin main explicitly before running
the affected build.
git fetch origin main only populates FETCH_HEAD, which turbo's --affected merge-base lookup can't resolve as 'main'. Fetch directly into a local main branch ref instead.
odinr
force-pushed
the
chore/fusion-lint-warnings
branch
from
August 19, 2026 17:47
95e3195 to
6f6fc2f
Compare
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
fusion-lint lint packagesreported twowarn-level diagnostics that were not yet resolved: asingle-export-per-filewarning inschemas.tsand fourrequire-intent-comment/flowwarnings inNavigationProvider.ts.What is the current behavior?
FrameworkOptionsSchemawas the only export inschemas.tswithout the file's existing co-location-suppression comment, even though it's intentionally exported alongsideApiApplicationBuildSchema/ApiApplicationSchema, which already use that convention.for,if,if, andwhileblocks innormalizePathname/stripTrailingSlasheshad no intent comments.What is the new behavior?
FrameworkOptionsSchemanow has the same// Deliberately co-located ... fusion-lint-disable-next-line single-export-per-filecomment pattern already used elsewhere in the file.What is the intended behavior or invariant?
No functional change — comment-only fixes to satisfy
fusion-lint'ssingle-export-per-fileandrequire-intent-comment/flowrules.Does this PR introduce a breaking change?
No.
Impact assessment:
Review guidance:
Comment-only changes; verified with
fusion-lint lint packages/modules/app packages/modules/navigation(no problems found) andbiome checkon both files.Additional context
None.
Related issues
None.
Checklist