Skip to content

Adapt to ruff recommendations - #1159

Merged
Eddasol merged 8 commits into
equinor:mainfrom
Eddasol:ruff
Aug 11, 2026
Merged

Adapt to ruff recommendations#1159
Eddasol merged 8 commits into
equinor:mainfrom
Eddasol:ruff

Conversation

@Eddasol

@Eddasol Eddasol commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like logging, TODO, etc.
  • The PR has been tested locally
  • A test has been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that requires new issues
  • The changes do not introduce dead code as unused imports, functions etc.

@Eddasol
Eddasol force-pushed the ruff branch 2 times, most recently from 5065255 to b332709 Compare August 6, 2026 07:57
@Eddasol
Eddasol force-pushed the ruff branch 2 times, most recently from 5706f26 to 58a4537 Compare August 6, 2026 08:14
@Eddasol
Remove unnecessary specifications
8b3d1e5 
Unnecessary 'pass' and 'return'
UP004: All classes inherit from object. No need to
specify
UP043: Unnecessary default type arguments
@Eddasol
Eddasol force-pushed the ruff branch 10 times, most recently from 3109b0b to 4f0cdfa Compare August 6, 2026 12:39
@Eddasol
Eddasol force-pushed the ruff branch 3 times, most recently from dfb2dec to 37d1426 Compare August 6, 2026 14:33
marianards
marianards reviewed Aug 7, 2026
View reviewed changes
Comment thread src/isar/models/events.py
marianards
marianards reviewed Aug 7, 2026
View reviewed changes
Comment thread src/isar/models/events.py Outdated
marianards
marianards reviewed Aug 7, 2026
View reviewed changes
Comment thread src/isar/robot/robot_battery.py Outdated
marianards
marianards reviewed Aug 7, 2026
View reviewed changes
Comment thread src/isar/robot/robot_status.py Outdated
marianards
marianards reviewed Aug 7, 2026
View reviewed changes
Comment thread src/isar/services/utilities/scheduling_utilities.py Outdated
marianards
marianards reviewed Aug 7, 2026
View reviewed changes
Comment thread src/isar/robot/robot_pause_mission.py
@Eddasol
Eddasol force-pushed the ruff branch 2 times, most recently from 6a2eb1c to 54a1cc2 Compare August 7, 2026 07:46
marianards
marianards reviewed Aug 7, 2026
View reviewed changes
Comment thread src/isar/robot/robot_inspection_service.py Outdated
marianards
marianards reviewed Aug 7, 2026
View reviewed changes
Comment thread src/isar/robot/robot_service.py Outdated
@Eddasol Eddasol mentioned this pull request Aug 7, 2026
Closed
@Eddasol Eddasol changed the title Remove deprecated typing Adapt to ruff recommendations Aug 7, 2026
@Eddasol Eddasol self-assigned this Aug 7, 2026
@Eddasol
Eddasol requested a review from marianards August 7, 2026 13:44
andchiind
andchiind approved these changes Aug 10, 2026
View reviewed changes

@andchiind andchiind left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread tests/test_mocks/robot_interface.py
@Eddasol
Eddasol merged commit e2585c2 into equinor:main Aug 11, 2026
4 checks passed
@Eddasol
Eddasol deleted the ruff branch August 11, 2026 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andchiind andchiind andchiind approved these changes
@marianards marianards Awaiting requested review from marianards

Assignees

@Eddasol Eddasol

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Eddasol @andchiind @marianards