Allow parameters (X) to use a different dtype than observations in ESMDA - #324
Merged
Conversation
- Replace ALLOWED_DTYPES whitelist with np.issubdtype checks, accepting any floating-point dtype instead of only float16/32/64 - Remove dtype enforcement on X (parameters); responses (Y) must still match the observations dtype - Preserve X's original dtype in assimilate_batch by casting the ensemble-space update before multiplying with delta_M, avoiding a parameter-sized float64 intermediate - Raise TypeError instead of ValueError for non-floating inputs
dafeda
force-pushed
the
remove-type-enforcment
branch
from
March 24, 2026 05:43
d05dde9 to
e6bfcee
Compare
dafeda
changed the title
tommyod
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #322