Fallback to gesvd in invert_subspace on failure - #381
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a robustness improvement to the ESMDA subspace inversion routine by retrying SVD with a more stable LAPACK driver when the default driver fails to converge, along with a regression test to ensure the fallback path behaves as intended.
Changes:
- Add
gesvdfallback and warning ininvert_subspacewhensp.linalg.svdraisesLinAlgError(non-convergence). - Add a unit test that monkeypatches
scipy.linalg.svdto forcegesddfailure and verify fallback + warning + identical numerical result.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/iterative_ensemble_smoother/esmda_inversion.py |
Wraps SVD in try/except to warn and retry with lapack_driver="gesvd" on failure. |
tests/test_esmda_inversion.py |
Adds a focused test to ensure the gesdd→gesvd fallback is exercised and produces the same result. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
larsevj
force-pushed
the
fallback_to_gesvd_in_svd_call
branch
from
August 4, 2026 07:21
e48ab05 to
cea6f9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.