Potential fix for code scanning alert no. 13: Incomplete URL substring sanitization - #3
Draft
Hjaf wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 13: Incomplete URL substring sanitization#3Hjaf wants to merge 1 commit into
Hjaf wants to merge 1 commit into
Conversation
…g sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/equinor/power-platform-skills/security/code-scanning/13
Use URL parsing in the test and assert exact hostname presence rather than substring presence.
Best fix (without changing functionality): in
plugins/power-pages/scripts/tests/render-alm-plan.test.js, update the assertion around line 1519 to:chosenEnvUrlusingnew URL(...)..hostname.Since this is test code and we already have the full URL literal in the fixture, parsing it avoids “substring sanitization” patterns and keeps the same intent (“surface chosen env URL host”). No new imports are needed because
URLis globally available in Node.js.Suggested fixes powered by Copilot Autofix. Review carefully before merging.