Feat/ef migration final

[EinarSalbouvet]

No description provided.

[rupakkatwal]

Nice work!
Some comments

[rupakkatwal]

can also be added those properties in outgoingdto?

[rupakkatwal]

In ProjectRole Update: With Update first, the foreach loop iterates over entities that might be deleted in the next step.`
Also this update make ProjectRoleRepository UpdateRangeAsync Redundant? same with other like objectives, strategy etc.

[EinarSalbouvet]

good point on the project role, I will look into what update methods can be reduced by calling these extensions

[rupakkatwal]

Curious,Why Column field is removed from all the entities?

[EinarSalbouvet]

the column attribute determines the name the prop has in the database. It was there before to match the column names we had, but since we are remaking the database we no longer need the column attribute

[rupakkatwal]

nice work!
Some comments and suggeastions.

[rupakkatwal]

also add
entity.IconColor = incommingEntity.IconColor;

[rupakkatwal]

Suggested change

	public static async Task RemoveOutOfScopeStrategyOptions(this Issue entity, Issue incommingEntity, AppDbContext context)
	{
	if (!RepositoryUtilities.IsDecisionMovedOutOfStrategyTable(entity, incommingEntity)) return;
	var strategyOptionsToBeRemoved = await context.StrategyOptions
	.Where(e => e.Option!.Decision!.IssueId == entity.Id)
	.ToListAsync();
	if (strategyOptionsToBeRemoved.Count != 0)
	{
	context.StrategyOptions.RemoveRange(strategyOptionsToBeRemoved);
	await context.SaveChangesAsync();
	}
	}
	public static async Task RemoveOutOfScopeStrategyOptions(this Decision entity, Decision incommingEntity, AppDbContext context)
	{
	if (!RepositoryUtilities.IsDecisionMovedOutOfStrategyTable(entity, incommingEntity)) return;
	var strategyOptionsToBeRemoved = await context.StrategyOptions
	.Where(e => e.Option!.DecisionId == entity.Id)
	.ToListAsync();
	if (strategyOptionsToBeRemoved.Count != 0)
	{
	context.StrategyOptions.RemoveRange(strategyOptionsToBeRemoved);
	await context.SaveChangesAsync();
	}
	}
	public static async Task RemoveOutOfScopeStrategyOptions(this Issue entity, Issue incommingEntity, AppDbContext context)
	{
	if (!RepositoryUtilities.IsDecisionMovedOutOfStrategyTable(entity, incommingEntity)) return;
	await RemoveStrategyOptions(context, e => e.Option!.Decision!.IssueId == entity.Id);
	}
	public static async Task RemoveOutOfScopeStrategyOptions(this Decision entity, Decision incommingEntity, AppDbContext context)
	{
	if (!RepositoryUtilities.IsDecisionMovedOutOfStrategyTable(entity, incommingEntity)) return;
	await RemoveStrategyOptions(context, e => e.Option!.DecisionId == entity.Id);
	}
	private static async Task RemoveStrategyOptions(AppDbContext context, Expression<Func<StrategyOption, bool>> predicate)
	{
	var strategyOptionsToBeRemoved = await context.StrategyOptions
	.Where(predicate)
	.ToListAsync();
	if (strategyOptionsToBeRemoved.Count != 0)
	{
	context.StrategyOptions.RemoveRange(strategyOptionsToBeRemoved);
	await context.SaveChangesAsync();
	}
	}

[rupakkatwal]

context is unused here.

[rupakkatwal]

since the incoming list is pre-filtered to match existing entities, methods RemoveMissingFromCollectionMutate and GetEntitiesToBeAdded inside entity.update effectively does nothing (both lists have the same IDs).

found the same in OutcomeRepository,ProjectRoleRepository, and strategy Repository.