Fix/slow loading issue and graph api user search#272
Open
rupakkatwal wants to merge 5 commits intofeat/dotnet-apifrom
Open
Fix/slow loading issue and graph api user search#272rupakkatwal wants to merge 5 commits intofeat/dotnet-apifrom
rupakkatwal wants to merge 5 commits intofeat/dotnet-apifrom
Conversation
EinarSalbouvet
requested changes
Mar 24, 2026
Collaborator
EinarSalbouvet
left a comment
EinarSalbouvet
left a comment
There was a problem hiding this comment.
Nice work, just a couple comments
Comment on lines
+38
to
42
| [HttpGet("users/azure-id/{azureId}")] | ||
| public async Task<ActionResult<UserOutgoingDto>> GetUserByAzureId(string azureId) | ||
| { | ||
| var result = await _userService.GetAsync(new List<string> { id }); | ||
| var result = await _userService.GetAsync([azureId]); | ||
| return result.Count > 0 ? Ok(result[0]) : NotFound(); |
Collaborator
There was a problem hiding this comment.
with the changes to the database the azure id is now just the user id
| { | ||
| config.QueryParameters.Search = $"\"displayName:{sanitizedQuery}\" OR \"mail:{sanitizedQuery}\""; | ||
| config.QueryParameters.Select = new[] { "id", "displayName", "mail", "userPrincipalName" }; | ||
| config.QueryParameters.Top = 100; |
Collaborator
There was a problem hiding this comment.
We might want to have some of these as application constants
Comment on lines
+98
to
+104
| private static string SanitizeSearchQuery(string query) | ||
| { | ||
| var sanitized = query.Trim(); | ||
| sanitized = Regex.Replace(sanitized, @"\s+", " "); | ||
| sanitized = Regex.Replace(sanitized, @"[""'\\(){}[\];]", string.Empty); | ||
| return sanitized; | ||
| } |
Collaborator
There was a problem hiding this comment.
suggestion: This seems useful as a string extension, so it can be used every where. that would require a rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.