Fix Warning Message for Skipped Test Due to Missing 'opm' Package - #480
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 17 17
Lines 2723 2723
=======================================
Hits 2689 2689
Misses 34 34 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses the issue with the skipped test in tests/test_wateroilgas.py. The test was being skipped with the message: "ecl2df not installed." This was misleading because the test's functionality depends on the opm package, not ecl2df.
Changes Made:
The warning message has been modified to: "opm not installed. See https://pypi.org/project/opm/" providing clearer guidance to developers and users regarding the dependency required to run the test successfully.
Testing:
The modified warning message has been tested to ensure that it now correctly informs users about the missing opm package when the test is skipped.