Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum CMake version to 3.11 #610

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

ajaust
Copy link
Contributor

@ajaust ajaust commented Apr 3, 2025

Red Hat Enterprise Linux (RHEL) 7 has reached its end of life in 2024. This means we can bump the minimum required version to 3.11 which is provided in RHEL 8 1. We assume that other systems either have CMake 3.11 or newer available, or have a way to install a sufficently new CMake versions.

Bumping the minimum version removes some deprecation warning (about support for older CMake versions being dropped), and also ensures compatibility with CMake 4.0 which has dropped support for CMake <3.5 and was rolled out to GitHub runners recently.

Copy link
Contributor

@achaikou achaikou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

  1. Should we also update cmake version in setup-CMakeLists.txt
  2. Should the version in README be updated?

Copy link
Contributor

@achaikou achaikou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Rebase and merge.

Minimum required version makes sense as Red Hat 8 seems to have oldest cmake from currently alive major systems.
Also segyio 2.0 is a good opportunity to bump required cmake several versions higher.

Red Hat Enterprise Linux (RHEL) 7 has reached its end of life in 2024.
This means we can bump the minimum required version to 3.11 which is
provided in RHEL 8 [1]. We assume that other systems either have CMake
3.11 or newer available, or have a way to install a sufficently new
CMake versions.

Bumping the minimum version removes some deprecation warning (about
support for older CMake versions being dropped), and also ensures
compatibility with CMake 4.0 which has dropped support for CMake <3.5
and was rolled out to GitHub runners recently.

[1]: https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/8/html-single/8.0_release_notes/index#platform-tools
@ajaust ajaust force-pushed the maint/update-cmake-version branch from d546194 to 3e2cbe6 Compare April 4, 2025 12:17
@ajaust ajaust merged commit 30bc298 into equinor:main Apr 4, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants