Skip to content

Disallow merged cells in Excel input for fmudesign - #759

Merged
dafeda merged 2 commits into
equinor:mainfrom
tommyod:merged-cells
Sep 24, 2025
Merged

Disallow merged cells in Excel input for fmudesign#759
dafeda merged 2 commits into
equinor:mainfrom
tommyod:merged-cells

Conversation

@tommyod

@tommyod tommyod commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

Closes #667

@berland

berland commented Sep 23, 2025

Copy link
Copy Markdown
Collaborator

What happens for users with xls files that have accicentally(?) merged some cells and using those xls files in their FMU setups? Could there be a situation where the merged cells are not involved in the operations and thus it would work fine, but break now?

@berland

berland commented Sep 23, 2025

Copy link
Copy Markdown
Collaborator

From a Kusto query, there seems to be a few users running fmudesign as a workflow in Ert. I extracted xlsx filenames (31 unique the last 6 months) and ran the new fmudesign on these. I got no errors about merged cells so this is probably safe to merge.

(additionally I could see from the logs that they did not necessarily use the Komodo fmudesign so they don't even get the benefit)

@tommyod

tommyod commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

What happens for users with xls files that have accicentally(?) merged some cells and using those xls files in their FMU setups? Could there be a situation where the merged cells are not involved in the operations and thus it would work fine, but break now?

It would fail. Yes, that is possible. As such it is a breaking change, but not a breaking change wrt expected, correct input. So I would consider it a bugfix.

Good that you did a check!

@dafeda
dafeda merged commit 72f1a5f into equinor:main Sep 24, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fmudesign: Detect merged cells in design matrix

3 participants