Change ahmanalysis to use ensemble.load_scalars() - #772
Merged
Conversation
jonathan-eq
force-pushed
the
remove-manifest-file
branch
2 times, most recently
from
October 7, 2025 13:47
9a5964a to
41cca80
Compare
jonathan-eq
force-pushed
the
remove-manifest-file
branch
from
October 8, 2025 09:52
41cca80 to
4e588be
Compare
jonathan-eq
commented
Oct 9, 2025
Comment on lines
+198
to
+201
| prior_data.columns.name = None | ||
| prior_data.index.name = "Realization" | ||
| prior_data = prior_data.sort_index(axis=1) | ||
| prior_data = prior_data.set_index("realization") |
Contributor
Author
There was a problem hiding this comment.
This is the logic that differed between load_scalarsand load_all_gen_kw_data. In the first round, we will just move it here, but the next one should rewrite this to polars instead of keeping pandas.
9 tasks
xjules
approved these changes
Oct 10, 2025
xjules
left a comment
xjules
left a comment
Contributor
There was a problem hiding this comment.
Looks fine. At some point we should drop out pandas here too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✂️