Skip to content

feat: create availability alert#98

Draft
hknutsen wants to merge 19 commits intomainfrom
feat/create-reduced-availability-alert
Draft

feat: create availability alert#98
hknutsen wants to merge 19 commits intomainfrom
feat/create-reduced-availability-alert

Conversation

@hknutsen
Copy link
Copy Markdown
Member

@hknutsen hknutsen commented Aug 29, 2024 •
edited
Loading

No description provided.

@hknutsen
feat!: create reduced availability alert
3ec08f3 
BREAKING CHANGE: add required variable `action_group_id`
@hknutsen hknutsen mentioned this pull request Aug 29, 2024
Open
5 tasks
@hknutsen

This comment was marked as outdated.

Sign in to view
@hknutsen hknutsen marked this pull request as ready for review October 30, 2024 10:08
@hknutsen hknutsen requested a review from a team as a code owner October 30, 2024 10:08
@hknutsen
Copy link
Copy Markdown
Member Author

hknutsen commented Oct 30, 2024

@equinor/terraform-baseline-maintainers Should I write a more detailed migration guide, for example in a document docs/migrate-to-v12.md?

@helenakallekleiv
Copy link
Copy Markdown
Contributor

helenakallekleiv commented Oct 30, 2024

@equinor/terraform-baseline-maintainers Should I write a more detailed migration guide, for example in a document docs/migrate-to-v12.md?

I think that could be helpful, yes!
Do you want to include the migration guide in this PR, or in a new one?

helenakallekleiv
helenakallekleiv previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@helenakallekleiv helenakallekleiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is very good as is, but a migration guide as you suggested could be beneficial!

@sebastianlolv
Copy link
Copy Markdown
Contributor

sebastianlolv commented Nov 6, 2024

@hknutsen Is this on hold to create the migration guide or will you make seperate PR?

@hknutsen
Copy link
Copy Markdown
Member Author

hknutsen commented Nov 25, 2024

Converting to draft again to discuss even further. Still scared that this might lead to feature creep.

@hknutsen hknutsen marked this pull request as draft November 25, 2024 07:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 27, 2025

There has been no activity on this pull request for 60 days. stale label will be added. If no additional activity occurs, the pull request will be closed in 7 days.

@github-actions github-actions Bot added the stale label Jan 27, 2025
@hknutsen hknutsen changed the title feat!: create reduced availability alert feat: create reduced availability alert Jul 16, 2025
@hknutsen hknutsen changed the title feat: create reduced availability alert feat: create availability alert Jul 16, 2025
@hknutsen hknutsen force-pushed the feat/create-reduced-availability-alert branch from ef84fb9 to fadc398 Compare July 24, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@helenakallekleiv helenakallekleiv helenakallekleiv left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hknutsen @helenakallekleiv @sebastianlolv