Skip to content

feat!: formations#13

Merged
kjerandp merged 3 commits intomainfrom
feat/formations
Apr 15, 2025
Merged

feat!: formations#13
kjerandp merged 3 commits intomainfrom
feat/formations

Conversation

@kjerandp
Copy link
Copy Markdown
Collaborator

Made picks dependent on stratigraphy column instead of having color and unit baked-in. A new formation type was added to generate formation entries and exits based on picks and strat-column. Also added an experimental ribbon geometry to the SDK.

…and unit baked-in. A new formation type was added to generate formation entries and exits based on picks and strat column. Also added an experimental ribbon geometry to the SDK.
@kjerandp kjerandp marked this pull request as draft April 1, 2025 07:31
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 39.60573% with 337 lines in your changes missing coverage. Please review.

Project coverage is 8.31%. Comparing base (c2d94c5) to head (859901a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/sdk/geometries/curve/ribbon-geometry.ts 0.00% 108 Missing ⚠️
.../generators/wellbore-formation-column-generator.ts 0.00% 76 Missing ⚠️
src/sdk/materials/ribbon-material.ts 0.00% 73 Missing ⚠️
src/generators/picks-generator.ts 0.00% 19 Missing ⚠️
src/sdk/data/helpers/picks-helpers.ts 93.58% 15 Missing ⚠️
src/sdk/managers/CameraManager.ts 0.00% 11 Missing ⚠️
src/sdk/utils/trajectory.ts 0.00% 11 Missing ⚠️
src/sdk/geometries/curve/tube-geometry.ts 0.00% 10 Missing ⚠️
src/sdk/utils/strings.ts 0.00% 3 Missing ⚠️
...ponents/Wellbores/WellboreFormationColumn/index.ts 0.00% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #13      +/-   ##
========================================
+ Coverage   4.77%   8.31%   +3.54%     
========================================
  Files        130     137       +7     
  Lines       5198    5714     +516     
  Branches     174     229      +55     
========================================
+ Hits         248     475     +227     
- Misses      4950    5239     +289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kjerandp kjerandp marked this pull request as ready for review April 1, 2025 10:32
@kjerandp kjerandp marked this pull request as draft April 1, 2025 12:35
@kjerandp kjerandp marked this pull request as ready for review April 1, 2025 13:16
@kjerandp kjerandp merged commit 0248bf5 into main Apr 15, 2025
4 checks passed
@kjerandp kjerandp deleted the feat/formations branch April 15, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants