Skip to content

fix: auto-positioned well labels appear mangled #2688 #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nilscb wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: auto-positioned well labels appear mangled #2688 #2691

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0cccae4
fix: Regression: auto-positioned well labels appear mangled #2688
nilscb Jan 20, 2026
378a91f
fix lint
nilscb Jan 20, 2026
331569e
code comment fix
nilscb Jan 20, 2026
170e0e7
fix: revert of defect: "Subsurface Viewer: WellLabelLayer has signifi…
nilscb Jan 22, 2026
6cd265b
Merge branch 'master' into TmpBranch
hkfb Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions typescript/packages/subsurface-viewer/src/layers/wells/layers/wellLabelLayer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@ import _ from "lodash";
import { Vector2, Vector3 } from "math.gl";

import type { Color, PickingInfo } from "@deck.gl/core";
import {
OrbitViewport,
type DefaultProps,
type UpdateParameters,
} from "@deck.gl/core";
import { type DefaultProps, type UpdateParameters } from "@deck.gl/core";
import type { TextLayerProps } from "@deck.gl/layers";

import type { Feature, Position } from "geojson";
Expand Down Expand Up @@ -153,7 +149,6 @@ export class WellLabelLayer extends MergedTextLayer<
sublayerProps?.updateTriggers?.["getAngle"] ?? [];
const positionUpdateTriggers =
sublayerProps?.updateTriggers?.["getPosition"] ?? [];

const newProps = {
...sublayerProps,
getPosition: (d: WellFeature) => {
Expand All @@ -167,10 +162,7 @@ export class WellLabelLayer extends MergedTextLayer<
...sublayerProps?.updateTriggers,
getAngle: [
...angleUpdateTriggers,
this.context.viewport.constructor === OrbitViewport
? (this.context.viewport as OrbitViewport)
.cameraPosition
: null, // No need for angle update trigger for OrthographicViewport and change in camera.
this.context.viewport.cameraPosition,
this.props.orientation,
this.props.getPositionAlongPath,
],
Expand All @@ -179,6 +171,11 @@ export class WellLabelLayer extends MergedTextLayer<
this.context.viewport.cameraPosition,
this.props.getPositionAlongPath,
],

all: [
this.context.viewport.cameraPosition,
this.props.getPositionAlongPath,
],
},
};

Expand Down
Loading