-
Notifications
You must be signed in to change notification settings - Fork 10
Framework - preserve plot state #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Anders2303
wants to merge
10
commits into
equinor:main
Choose a base branch
from
Anders2303:framework/preserve_plot_state
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Framework - preserve plot state #1002
Anders2303
wants to merge
10
commits into
equinor:main
from
Anders2303:framework/preserve_plot_state
+200
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenthoms
requested changes
Jun 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all looks good 👍 You have some name discrepancies + some other minor considerations.
frontend/src/modules/SimulationTimeSeries/view/utils/PlotBuilder.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a wrapper around
plotly-react
that should make ui state more stable. All this is doing is creating stable copies of provided data and layout objects, and injecting theuirevision
prop to a fixed string if none is given (implementers can still trigger ui-resets by setting the prop manually, if needed).Generally, this makes plots more stable, and partially solves #223, but there are still cases where where the ui ends up resetting, and it's hard to pinpoint exactly what causes it. Some causes seem to be:
populated -> empty -> populated
)plotUpdateReady
prop to stop the component from updating internally while fetchingGenerally, all plot components should be refactored to: keep the plotly comp mounted, memoize data/layout, use the new prop to avoid uneccessary internal state updates
Future work
As mentioned, the uirevision approach is still very unstable. I think this band-aid solution is better than nothing, but we should probably consider a proper react-like ui state wrapper in the future, where we manually track ui changes and store them in the state, reapplying them each render (PR #231 presents a spike for this)