[DPF]: Adjusted hover visualization transformer definition and added hook for subscribing to WorkbenchServices
#1006
+118
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenthoms
changed the title
WorkbenchServicesWorkbenchServices
Anders2303
previously approved these changes
May 27, 2025
Comment on lines
+146
to
+154
| type KeysMatching<T, Pattern extends string> = { | ||
| [K in keyof T]: K extends Pattern ? K : never; | ||
| }[keyof T]; | ||
|
|
||
| type PickMatching<T, Pattern extends string> = { | ||
| [K in KeysMatching<T, Pattern>]: T[K]; | ||
| }; | ||
|
|
||
| export type HoverTopicDefinitions = PickMatching<GlobalTopicDefinitions, `global.hover${string}`>; |
Collaborator
There was a problem hiding this comment.
Instead of doing this, wouldn't it be easier to just split up the type in WorkbenchServices instead?
export type GlobalHoverTopicDefinitions {
"global.hover...": ...;
// ...
}
export type GlobalSyncValueTopicDefintions {
"global.syncValue...": ...
// ...
}
// etc...
export GlobalTopicDefinitions = GlobalHoverTopicDefinitions & GlobalSyncValueTopicDefintions & ...
Collaborator
|
@Anders2303 and @rubenthoms to check if still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.