Patch: Tag input/picker fixes #1238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lePicker height not matching tags
jorgenherje
requested changes
Oct 27, 2025
Collaborator
jorgenherje
left a comment
jorgenherje
left a comment
There was a problem hiding this comment.
Nice adjustments!
Some minor comments:
-
As discussed, the outline "blinks" when opening dropdown and selecting a new tag. As it looses focus when clicking in dropdown, and retain focus when input field becomes active again.
-
I still get some issues with autoscroll when hovering a the bottom of the virtualization component (I get the same issue for standard picker in MyModule2):
https://github.com/user-attachments/assets/761b561a-ffeb-45e0-aaaf-b7664b0273a6 -
See further comments below
frontend/src/framework/components/EnsemblePicker/private-components/ensembleTag.tsx
Outdated
Show resolved
Hide resolved
frontend/src/framework/components/EnsemblePicker/private-components/ensembleTag.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes assorted smaller issues in the
TagPicker,TagInputandEnsemblePickercomponentsTagInputpadding classesinputPropsproperty in theTagPickercomponentEnsemblePickerto match tag heightdropdownMinWidthprop toTagPicker. Defaults to 120pxTagPickerwould reset list focus too easilyTagInputTagPickerdropdown would scrollI just tweaked the padding to make the list perfectly fit the amount of items. A more proper fix should separate hover and mouse focus movement but I want to wait with that until the hooks introduced in Updated virtualization logic to avoid re-rendering #1075 are availableTagInput(clicking the entire component root, instead of just the input field). The input field will also wrap around a little earlier now.