BLD: add support for python 3.13 #1329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1329 +/- ##
==========================================
+ Coverage 80.02% 81.38% +1.35%
==========================================
Files 98 94 -4
Lines 13680 12480 -1200
Branches 2203 1880 -323
==========================================
- Hits 10948 10157 -791
+ Misses 1999 1668 -331
+ Partials 733 655 -78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jcrivenaes
commented
Apr 24, 2025
| @@ -225,7 +224,7 @@ def export_rms_ascii(self, wfile, precision=4): | |||
| # make the disc as is np.int | |||
| for lname in self.wlogtypes: | |||
| if self.wlogtypes[lname] == _AttrType.DISC.value: | |||
| tmpdf[[lname]] = tmpdf[[lname]].astype(int) | |||
| tmpdf[[lname]] = tmpdf[[lname]].fillna(-999).astype(int) | |||
There was a problem hiding this comment.
Python 3.13 seems somewhat stricter on casting, and also on escape character
mferrera
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1318