Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Run-Length Encoding (RLE) compression support for the ZCORN keyword when exporting grid data to GRDECL format. Previously, RLE compression was only available for the ACTNUM keyword. This enhancement is particularly beneficial for horizontal grids where ZCORN values have many consecutive repetitions.
Key Changes:
- Extended RLE compression to include ZCORN in addition to ACTNUM
- Updated test validation to verify compression works correctly for both ZCORN and ACTNUM keywords
- Improved test robustness with a helper function to parse specific keyword sections
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/xtgeo/grid3d/_grdecl_grid.py |
Modified the RLE condition to include "ZCORN" alongside "ACTNUM" for compression |
tests/test_grid3d/test_grid_property.py |
Enhanced test validation with section-specific token parsing and verification of ZCORN compression |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mferrera
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1486
Add support for ZCORN keyword to Run-Length Encoding compression. This is particularly useful for horizontal grid
Checklist
--cov=src/ --cov-report term-missing)