Skip to content

Comments

BLD: Pin eigen3#1489

Merged
mferrera merged 1 commit intoequinor:mainfrom
mferrera:try-pin-eigen
Jan 5, 2026
Merged

BLD: Pin eigen3#1489
mferrera merged 1 commit intoequinor:mainfrom
mferrera:try-pin-eigen

Conversation

@mferrera
Copy link
Collaborator

@mferrera mferrera commented Jan 5, 2026

Resolves #1488

Eigen3 v5.0.0 was released on vcpkg. This pins the version for the Windows build.

Checklist

  • Tests added (if not, comment why)
  • Test coverage equal or up from main (run pytest with --cov=src/ --cov-report term-missing)
  • If not squash merging, every commit passes tests
  • Appropriate commit prefix and precise commit message used
  • All debug prints and unnecessary comments removed
  • Docstrings are correct and updated
  • Documentation is updated, if necessary
  • Latest main rebased/merged into branch
  • Added comments on this PR where appropriate to help reviewers
  • Moved issue status on project board
  • Checked the boxes in this checklist ✅

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.65%. Comparing base (0375fed) to head (bb18153).
⚠️ Report is 159 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1489      +/-   ##
==========================================
- Coverage   80.02%   79.65%   -0.38%     
==========================================
  Files          98      103       +5     
  Lines       13680    14389     +709     
  Branches     2203     2246      +43     
==========================================
+ Hits        10948    11461     +513     
- Misses       1999     2196     +197     
+ Partials      733      732       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mferrera mferrera force-pushed the try-pin-eigen branch 4 times, most recently from b0a719d to ae7f71a Compare January 5, 2026 07:11
@mferrera mferrera marked this pull request as ready for review January 5, 2026 07:21
@mferrera mferrera self-assigned this Jan 5, 2026
@mferrera mferrera requested a review from a team January 5, 2026 07:32
@mferrera mferrera merged commit feaf8be into equinor:main Jan 5, 2026
38 checks passed
@mferrera mferrera deleted the try-pin-eigen branch January 5, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xtgeo windows build timing out

3 participants