Skip to content

CI: Add testrmsenv.sh script for testing against RMS environment - #92

Merged
AdilKhurshid merged 1 commit into
equinor:mainfrom
AdilKhurshid:rms-ci
Jun 25, 2026
Merged

CI: Add testrmsenv.sh script for testing against RMS environment#92
AdilKhurshid merged 1 commit into
equinor:mainfrom
AdilKhurshid:rms-ci

Conversation

@AdilKhurshid

@AdilKhurshid AdilKhurshid commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Resolves #361
https://github.com/equinor/rms-sys/issues/361

Added ci/testrmsenv.sh to enable validation of newly built RMS environments by running its unit tests against them.

Checklist

  • Tests added (if not, comment why)
  • Test coverage equal or up from main (run pytest with --cov=src/ --cov-report term-missing)
  • If not squash merging, every commit passes tests
  • Appropriate commit prefix and precise commit message used
  • All debug prints and unnecessary comments removed
  • Docstrings are correct and updated
  • Documentation is updated, if necessary
  • Latest main rebased/merged into branch
  • Added comments on this PR where appropriate to help reviewers
  • Moved issue status on project board
  • Checked the boxes in this checklist ✅

@AdilKhurshid
AdilKhurshid force-pushed the rms-ci branch 2 times, most recently from f7dda4e to bdd943d Compare June 25, 2026 12:34

@GibranAlfa GibranAlfa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should not use uv here, as like we did in other testrmsenv.sh in https://github.com/equinor/xtgeo/blob/main/ci/testrmsenv.sh for example,, uv might not resolve the correct python from RMS env

@AdilKhurshid

Copy link
Copy Markdown
Contributor Author

i think we should not use uv here, as like we did in other testrmsenv.sh in https://github.com/equinor/xtgeo/blob/main/ci/testrmsenv.sh for example,, uv might not resolve the correct python from RMS env

Done

@AdilKhurshid
AdilKhurshid requested a review from GibranAlfa June 25, 2026 12:58
Comment thread ci/testrmsenv.sh
copy_test_files () {
echo "Copy xtgeoviz test files to $CI_TEST_ROOT..."
mkdir -p $CI_TEST_ROOT
cp -r $PROJECT_ROOT/tests $CI_TEST_ROOT

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xtgeoviz tests still resolve testdata through ../xtgeo-testdata in several places, and in the rms-sys workflow pytest runs from $CI_ROOT/xtgeoviz_test_root while the cached testdata lives at $XTGEO_TESTDATA_PATH. We can add a symlink from $CI_ROOT/xtgeo-testdata to $XTGEO_TESTDATA_PATH before running pytest. The --testdatapath argument is accepted, but it is not used by all xtgeoviz tests.

Suggested change
cp -r $PROJECT_ROOT/tests $CI_TEST_ROOT
ln -s $XTGEO_TESTDATA_PATH $CI_ROOT/xtgeo-testdata
cp -r $PROJECT_ROOT/tests $CI_TEST_ROOT

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@AdilKhurshid
AdilKhurshid merged commit c7f29e6 into equinor:main Jun 25, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants