Skip to content

Implements drag and drop upload in creating issues #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 99 commits into
base: master
Choose a base branch
from

Conversation

erbunao
Copy link
Owner

@erbunao erbunao commented May 23, 2014

No description provided.

describe ProjectsController do
let(:project) { create(:project) }
let(:user) { create(:user) }
let(:png) { fixture_file_upload(Rails.root + 'spec/fixtures/dk.png', 'image/png') }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [89/80]

dzaporozhets and others added 9 commits May 23, 2014 12:24
Implements drag and drop upload of image in every markdown-area
Signed-off-by: Dmitriy Zaporozhets <[email protected]>
Signed-off-by: Dmitriy Zaporozhets <[email protected]>
Signed-off-by: Dmitriy Zaporozhets <[email protected]>
Remove features raketask

As discussed

Fixes gitlabhq#1179
dzaporozhets and others added 30 commits May 26, 2014 21:54
Signed-off-by: Dmitriy Zaporozhets <[email protected]>
CSS truncation

Use css truncation for event titles on dashboard. Fix vertical align of timestamps
Improve rake test

Check for `system` call return value instead of `$?.exitstatus`
Signed-off-by: Dmitriy Zaporozhets <[email protected]>
Improve merge request page UX

Increase Discussions and Changes tabs size. Added count of changes and comment to it

Before and after:

![Screenshot 2014-05-27 12.08.42](https://dev.gitlab.org/uploads/dzaporozhets/gitlabhq/31fe70c9be/Screenshot_2014-05-27_12.08.42.png)
Review changelog

@dzaporozhets updates the changelog and notifies the team.
This reverts commit e9d4587, which is
incompatible with GitLab's built in LDAP user filter: a GitLab LDAP
filter is [added on top of the other filters used to find the
user](https://gitlab.com/gitlab-org/gitlab-ce/blob/982d4d51e8110bec280eb00db0fb756b062103d9/lib/gitlab/ldap/adapter.rb#L61)

Example GitLab LDAP filter: `(memberOf=cn=foo,dc=bar)`.

In contrast, an omniauth-ldap filter [replaces the 'normal'
filters](https://gitlab.com/gitlab-org/omniauth-ldap/blob/76d77543dec0c585bb4e974262f43675f9810953/lib/omniauth/strategies/ldap.rb#L55)

Example omniauth-ldap user filter:
`(&(uid=%{username})(memberOf=cn=foo,dc=bar))`.
Gitlab shell in upgrader guide

Fixes #1214
permissions for MR page

Signed-off-by: Dmitriy Zaporozhets <[email protected]>
Don't show remove branch button if you are not allowed to remove it

Fixes #1213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants