Skip to content

fix: add unmark deployment #6505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CeerDecy
Copy link
Member

What this PR does / why we need it:

fix: If the artifact is still referenced within the rollback point, do not need to mark the deployment as outdated.

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English If the artifact is still referenced within the rollback point, do not need to mark the deployment as outdated.
🇨🇳 中文 如果制品还在回滚点内被引用,则不需要标记deployment为outdated

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot erda-bot requested a review from iutx March 24, 2025 09:26
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 15.13%. Comparing base (a9ee675) to head (a404104).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...nal/tools/orchestrator/services/runtime/runtime.go 0.00% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6505      +/-   ##
==========================================
- Coverage   15.13%   15.13%   -0.01%     
==========================================
  Files        3683     3683              
  Lines      377049   377059      +10     
==========================================
  Hits        57067    57067              
- Misses     314537   314546       +9     
- Partials     5445     5446       +1     
Flag Coverage Δ
by-github-actions 15.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nal/tools/orchestrator/services/runtime/runtime.go 12.92% <0.00%> (-0.06%) ⬇️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sfwn

Copy link

stale bot commented Apr 15, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 15, 2025
@CeerDecy CeerDecy removed the wontfix label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants