extracted neighborship definition to standalone function#40
Merged
erdogant merged 1 commit intoJul 24, 2025
Merged
Conversation
extracted neighborship definition, so that in the following the neighborship can be defined by a user, in case necessary.
erdogant
approved these changes
Jul 24, 2025
Owner
|
Thank you for your contribution! I am going to look into it and make some checks. Do you have a toy example so that I can create a unit test for this specific case? |
Owner
|
I’ve been testing the new implementation and made a few adjustments. The neighborhood_generator got stuck in one of my tests, so I created an if statement that, if neighborhood_generator is used, then it uses the new function; otherwise, it uses the previous one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted neighborhood definition, so that in the following the neighborhood can be defined by a user, in case necessary.
The functionality stays the same as previously, now it is possible to define a custom neighborhood condition. This may be necessary for applications where neighborhoods persist over "borders" of signals, like with a moebius neighborhood in 2D images as an example in [1].
[1] J. Ferner, S. Huber, S. Messineo, A. Pop, and M. Uray, “Persistence-based Hough Transform for Line Detection,” May 22, 2025, arXiv: arXiv:2504.16114. doi: 10.48550/arXiv.2504.16114.