Skip to content

Conversation

@mattlangford
Copy link
Contributor

@mattlangford mattlangford commented Jul 24, 2025

It seems like relying on the default .clang-tidy config file means that --verify-config doesn't actually fail the call. This looks like it works when I add random characters to the .clang-tidy file in this repo

$ bazel build //... --config clang-tidy
...
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
.clang-tidy:9:1: error: unknown key 'asdf'
asdf
^~~~
Error: invalid configuration specified.
Invalid argument
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 0.192s, Critical Path: 0.09s
INFO: 7 processes: 4 action cache hit, 7 internal.
ERROR: Build did NOT complete successfully

@dotnwat
Copy link

dotnwat commented Jul 24, 2025

Confirmed locally that this PR addresses the issue. Thanks @mattlangford

@dotnwat
Copy link

dotnwat commented Jul 24, 2025

I think this probably fixes #69 as well. The simplest explanation is that I had introduced errors into the clang tidy configuration file and was experiencing silent fallbacks to the default config.

@erenon erenon merged commit 121041f into erenon:master Jul 26, 2025
1 check passed
@erenon
Copy link
Owner

erenon commented Jul 26, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants