Skip to content

Conversation

@keith
Copy link
Contributor

@keith keith commented Aug 13, 2025

If your execution and target platform differ, we have to make sure that
clang tidy, and the C++ toolchain, are configured for where the test
will execute, instead of where the test script is generated.

@erenon
Copy link
Owner

erenon commented Aug 15, 2025

Thanks! CI seems to be failing.

If your execution and target platform differ, we have to make sure that
clang tidy, and the C++ toolchain, are configured for where the test
will execute, instead of where the test script is generated.
@keith keith force-pushed the ks/correctly-set-clang_tidy_test-exec-groups branch from c45180f to 304249f Compare August 15, 2025 22:25
@keith
Copy link
Contributor Author

keith commented Aug 15, 2025

i'll leave off "@bazel_tools//tools/test:default_test_toolchain_type", for now, but that means with bazel 9.x+ that this could run on a different execution platform than the target platform (which was actually my goal here) even if you don't care about that case. probably fine since I imagine most folks won't care or have that setup, but something to note in case it comes up

@erenon
Copy link
Owner

erenon commented Aug 16, 2025

thanks!

@erenon erenon merged commit 496018e into erenon:master Aug 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants