Skip to content

Conversation

Lexiel46
Copy link

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16662611304

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.262%

Totals Coverage Status
Change from base Build 14508158401: 0.0%
Covered Lines: 79
Relevant Lines: 80

💛 - Coveralls

@Lexiel46 Lexiel46 merged commit 9c55f16 into master Aug 1, 2025
3 checks passed
@Lexiel46 Lexiel46 deleted the ERP-3676-Angular-20-upgrade branch August 1, 2025 00:03
@sonusindhu
Copy link

Hi,

Thanks for the upgrade to v20 but I see one issue while using that library

Pass - /projects/password-strength-meter/zxcvbn/src/password-strength-meter-zxcvbn.service.ts

still have reference from main library, it should "@eresearchqut/angular-password-strength-meter" ?

import {
FeedbackResult,
IPasswordStrengthMeterService,
} from 'angular-password-strength-meter';

Due to that, I am getting error while building for production

✘ [ERROR] Could not resolve "angular-password-strength-meter"

node_modules/@eresearchqut/angular-password-strength-meter/fesm2022/eresearchqut-angular-password-strength-meter-zxcvbn.mjs:3:46:
  3 │ ...swordStrengthMeterService } from 'angular-password-strength-meter';
    ╵                                  

Hope that make sense

@Lexiel46
Copy link
Author

Lexiel46 commented Sep 4, 2025

Hi,

Thanks for the upgrade to v20 but I see one issue while using that library

Pass - /projects/password-strength-meter/zxcvbn/src/password-strength-meter-zxcvbn.service.ts

still have reference from main library, it should "@eresearchqut/angular-password-strength-meter" ?

import { FeedbackResult, IPasswordStrengthMeterService, } from 'angular-password-strength-meter';

Due to that, I am getting error while building for production

✘ [ERROR] Could not resolve "angular-password-strength-meter"

node_modules/@eresearchqut/angular-password-strength-meter/fesm2022/eresearchqut-angular-password-strength-meter-zxcvbn.mjs:3:46:
  3 │ ...swordStrengthMeterService } from 'angular-password-strength-meter';
    ╵                                  

Hope that make sense

Hi @sonusindhu,

Thanks for the heads-up on this.

The import path you're seeing, angular-password-strength-meter, is defined as an alias in the tsconfig.json file. The paths configuration maps the angular-password-strength-meter alias to the actual file location as shown in the code snippet below.

"paths": {
  "angular-password-strength-meter": [
    "./dist/password-strength-meter"
  ],
  "angular-password-strength-meter/*": [
    "./dist/password-strength-meter/*"
  ],
  "angular-password-strength-meter/zxcvbn": [
    "./dist/password-strength-meter/zxcvbn"
  ]
}

I've installled this package in another application after the upgrade, and it's functioning correctly without the error you mentioned. To help me investigate, could you please provide more information about your project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants