Skip to content

huge init time optimization: protobuf & codegen insted of xml #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

greshnoff
Copy link

No description provided.

@erezak
Copy link
Owner

erezak commented Jul 19, 2014

Have you checked this with a Windows Phone? Does it generate code that can be loaded into a phone? This was the original reason I forked the lib.

@Ripper555
Copy link

I have not tested this on windows phone yet. I am running it on Android only right now. I'm using only:
PhoneNumberUtil.Normalize(phoneNumber);
_phone.Parse(nom, RegionCode.US);
_phone.IsValidNumber(ph);
_phone.Format(ph, PhoneNumberFormat.E164);

The initialize time on my phone is 3.250 seconds less time. The library is not usable except with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants