Fix upwind real bcs. #2705
Merged
Fix upwind real bcs. #2705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalmgren
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
The
ii/jjare limited on the domain, so they are valid to use with FAB data that exists everywhere. However, using those indices withu_arr/v_arrin the upwind BCs will lead to out of bounds errors when checking the sign of the velocity. Using limiters now to keep the indices bounded within the valid box of the variable.Testing
This bug was revealed by the Tornado case with UPW Real BCs and multiple ranks. Can confirm this case now runs in debug with the current PR.