-
Notifications
You must be signed in to change notification settings - Fork 20
DFT Matrices and Surrounding Lemmas #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
MohanadAhmed
wants to merge
24
commits into
eric-wieser:master
Choose a base branch
from
MohanadAhmed:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
May 17, 2023
|
|
||
| -- `matrix.is_hermitian.det_eq_prod_eigenvalues` is close, but needs `A` to be hermitian which is too strong | ||
| lemma eq_18 {A : matrix m m R} (eigvals : m → R) : det A = ∏ i, eigvals i := sorry | ||
| lemma eq_18 {A : matrix m m R} [is_alg_closed R] : det A = (eigs A).prod := det_eq_prod_eigs A |
Owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
DFT Matrix properties
Equations 403 through 412 and definitions necessary to state these lemmas such as DFT/IDFT on vectors, the DFT and Inverse DFT matrices.
We define three main matrices$W_n, sW_n = W_n^*, iW_n = \frac{1}{N}sW_n$ , the DFT matrix the conjugated DFT matrix and the inverse DFT matrix as a scaled conjugated DFT matrix. Other than the equations themselves there are supporting lemmas:
The comment between eq_411 and eq_412 stating that the DFT matrix is a vandermonde matrix is also formalized.
Wkn_dot_iWKn_offdiag: which shows that the product of the DFT matrix and its conjugate (or inverse) has zero of diagonal entries. This requires a lot of casting around!!Wₙ_mul_sWₙ:inverse_Wₙ:Wₙ_mul_iWₙ_eq_one:Wₙ_symmetricsWₙ_symmetriciWₙ_mul_Wₙ_eq_oneinv_Wₙtwiddle_comm'twiddle_sumconj_Wₙtwo_pi_I_by_N_piInt_pos: the imaginary part oftwo_pi_I_by_N_piInt_neg: the imaginary part oftwiddle_neg_half_cycle_eq_neg'raising a root of unity of denominator 2 or more to half its denominator gives minus 1shiftkandshiftk_equivallows shifting the summation overfin Nby arbitrary k.dft_idftandidft_dftshows that the dft and idft are inverse operations.notice_between_411_412the comment that the DFT matrix is a vandermonde matrixTrace and Determinant as Sum of Eigenavalues in closed fields
Added a file mat_eigs_lib.lean that contains definition of the eigenvalues set for finite matrices as the roots of the characteristic polynomial. Then we show that the sum and prod of these (possibly repeated eigenvalues) are the trace and determinant.
We then use these to prove eq_12 and eq_18
Minor Changes
linear_algebra.matrix.schur_complementsince it contains the matrix.det_from_blocks₂₂ and matrix.det_from_blocks_one₁₁ identities used by @eric-wieser in Equationseq_397andeq_398.Style
As you can see it is mostly rewrites. If you have pointers on how to improve my style and make it more efficient and varied in techniques, please share them!