req: add percentage complete #300
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Display for reference: plot id k tmp dst wall phase tmp pid stat pct mem user sys io
5ac4f255 32 /data/tmp/plot /mnt/external/plots 3:13 3:2 226G 482966 RUN 41% 5.3G 4:23 0:12 0:05
3aed4dec 32 /mnt/sdb1 /mnt/external/plots 3:56 3:2 206G 461155 DSK 52% 5.3G 4:40 0:13 0:16
7ec29aed 32 /mnt/sda1 /mnt/external/plots 4:26 3:4 184G 455588 RUN 64% 5.3G 4:54 0:15 0:24 |
rafaelsteil
reviewed
May 11, 2021
| else: | ||
| try: | ||
| # Get percent complete | ||
| finished_log_lines = 2626 |
Contributor
There was a problem hiding this comment.
Where does 2626 comes from?
Contributor
Author
There was a problem hiding this comment.
Take a look at the issue linked above for all the details, but that is the number of sequential log lines in a 128 plot (pulled from chia-gui sec)
Contributor
There was a problem hiding this comment.
Got it. Defining as a constant would be interesting just like Chia has FINISHED_LOG_LINES. I looked at the thread and compared to my own files, and they resulted in 2630 in almost all cases. Maybe 2626 is a "safer" value? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #297