Updated Code: handles zero devices, tests with vcr, extracted duplicated code into private methods#29
Open
mark-smithtb wants to merge 14 commits intoericboehs:masterfrom
Open
Conversation
mark-smithtb
commented
Nov 16, 2015
mark-smithtb
commented
- pulled post to device out of temperature methods into a private method.
- refactored to only pull structor and device ids if they exist.
- Added vcr to record interactions with the nest api for testing.
- Added timecop to freeze time for sets away status test to work with vcr.
Collaborator
|
Whoa. |
Owner
There was a problem hiding this comment.
You might want to change your password. Also this shouldn't be in the repo. :D
Owner
|
Could we put the fixtures in /spec/fixtures instead of /fixtures? Side note: We should set up circleci (or travis) and hound on this project. |
spec/spec_helper.rb
Outdated
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/nest_thermostat_spec.rb
Outdated
There was a problem hiding this comment.
Line is too long. [99/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.