Recursive link resolving for shell value #2388
Conversation
Add a test scenario where the specified shell is a (sym)link to a file that is itself a (sym)link.
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript |  |
Mar 4, 2026 4:43p.m. | Review ↗ |
Because on macOS we don't have a predictable binary to point to that we know Shescape knows (note that `/bin/sh` is not a symlink but not sufficient for identifying the shell).
This comment was marked as resolved.
This comment was marked as resolved.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7aca8f63ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as spam.
This comment was marked as spam.
This comment has been minimized.
This comment has been minimized.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: d76e5fa8-d00e-4bba-8c81-caf1cb2c7082
📒 Files selected for processing (10)
CHANGELOG.mdconfig/eslint.jspackage.jsonscript/double-link-sh.jssrc/internal/executables.jssrc/internal/unix.jstest/_constants.jstest/e2e/_common.jstest/unit/executables/resolve.test.jstest/unit/unix/index.test.js
This comment has been minimized.
This comment has been minimized.
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ericcornelissen
changed the title
shell value
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ericcornelissen
removed
test
2 participants
Summary
Add a test scenario where the specified shell is a (sym)link to a file that is itself a (sym)link.
This gap was identified by Codex.