Differentially test linear-time regexp support for migrated shells#2457
Closed
ericcornelissen wants to merge 10 commits intomainfrom
Closed
Differentially test linear-time regexp support for migrated shells#2457ericcornelissen wants to merge 10 commits intomainfrom
ericcornelissen wants to merge 10 commits intomainfrom
Conversation
Create a unit test that differentially tests the change in CMD escaping from "normal" regular expression to linear-time-based regular expressions (in [1]). To do this properly, the `shescape-previous` version is downgraded to the version prior to this migration. [1]: 0f38a42
ericcornelissen
force-pushed
the
differential-lregexp-testing
branch
from
27df91b to
19cb3d1
Compare
ericcornelissen
changed the title
Create a unit test that differentially tests the change in Bash escaping from "normal" regular expression to linear-time-based regular expressions (in [1]). The `bash.patch` file accounts for a later bug fix (see [2]). The extra `replace` in this suite accounts for *extra* (unnecessary) escaping in the new logic. [1]: 4f72b2a [2]: 6add105
Create a unit test that differentially tests the change for no-shell escaping from "normal" regular expression to linear-time-based regular expressions (in [1]). To do this properly, the `shescape-previous` version is downgraded to the version prior to this migration. [1]: 178160e
ericcornelissen
force-pushed
the
differential-lregexp-testing
branch
from
e285ced to
972ec23
Compare
Create a unit test that differentially tests the change in Csh escaping from "normal" regular expression to linear-time-based regular expressions (in [1]). The extra `replace` in this suite accounts for *extra* (unnecessary) escaping in the new logic. [1]: 5f822a6
This comment has been minimized.
This comment has been minimized.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ericcornelissen
added a commit
that referenced
this pull request
Apr 4, 2026
Owner
Author
|
This Pull Request was created purely to perform the differential (regression) testing. Hence, I'll close this soon now that each shell's escaping behavior has been confirmed. I just want to try and have the changes of #2446 covered by these tests as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #2122, #2129, #2304, #2325, #2358, #2383, cc1076d