feat(ci)🐳: Add Docker image build step to deployment workflow #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ericmjl
commented
Mar 4, 2025
ericmjl
commented
- Introduced a new job in the GitHub Actions workflow to build a Docker image.
- Updated the Dockerfile to use a new base image and streamlined the build process.
- Introduced a new job in the GitHub Actions workflow to build a Docker image. - Updated the Dockerfile to use a new base image and streamlined the build process.
- Updated the Docker build command to specify the Dockerfile location.
- Renamed the GitHub Actions workflow from 'Master branch deploy' to 'Deployments'. - This change improves the clarity and purpose of the workflow name.
|
- Included the mkdocs.yml file in the Docker image by copying it during the build process. - Ensured the documentation build step has access to the necessary configuration.
…text - Included the notebooks directory in the Dockerfile to ensure it is copied into the container. - This change supports the documentation build process by providing necessary resources.
- Deleted the command to build documentation during the container build process. - Removed the Python HTTP server setup and related commands.
- Replaced manual Docker build command with Docker Buildx setup and build-push action. - Configured the build-push action to tag the image as 'ericmjl/nams:latest'.
- Updated the deploy.yaml workflow to include the Dockerfile path. - This ensures the correct Dockerfile is used during the build process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.