Skip to content

Conversation

@kedarbhat
Copy link
Contributor

Closes #52

@kedarbhat
Copy link
Contributor Author

I've attached an archive with two html files generated by metabench (locally). meta_partition_current.htm refers to what one would find in meta.hpp in the master branch (in which partition uses fold). meta_partition_use_filter.htm refers to the proposed change (using filter to generate each of the lists generated by partitioning in the original list).

metabench_meta_partition.zip

{
using type = if_<invoke<Fn, A>, pair<list<Yes..., A>, list<No...>>,
pair<list<Yes...>, list<No..., A>>>;
using type = pair<filter<L<As...>, Fn>, filter<L<As...>, not_fn<quote<Fn::template invoke>>>>;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not_fn<quote<Fn::template invoke>> instead of just not_fn<Fn> ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not_fn<Fn> is the better syntax; I don't remember why I wrote that more verbosely than is necessary. I'll recommit with the more concise syntax.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed, fully built in my Appveyor/Travis accounts, build task 166.12 failed during libc++ installation. A restart of that task should pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants