Fix potential goroutine leak in httpreqresp.Do function#16691
Closed
Fix potential goroutine leak in httpreqresp.Do function#16691
Conversation
Contributor
Author
|
@Giulio2002 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Copilot
AI
changed the title
[WIP] Potential Goroutine Leak Due to Unbuffered Channel
Fix potential goroutine leak in httpreqresp.Do function
Aug 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Dofunction incl/sentinel/httpreqresp/server.gohad a potential goroutine leak due to an unbuffered channel. When the request context was cancelled before the HTTP handler completed, the goroutine would block indefinitely onans <- respbecause no receiver was available.Root Cause:
Solution:
Changed the channel to be buffered with capacity 1:
This allows the goroutine to send its response without blocking, even when the context cancellation case wins the race condition. The goroutine can complete normally and be garbage collected.
Testing:
Added comprehensive tests in
server_test.gothat verify:The fix is minimal (adding
, 1to the channel declaration) and maintains backward compatibility while preventing resource leaks.Fixes #16665.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.