cl/antiquary: avoid double-copying StateEvents into ETL#18668
Open
sashaodessa wants to merge 5 commits intoerigontech:mainfrom
Open
cl/antiquary: avoid double-copying StateEvents into ETL#18668sashaodessa wants to merge 5 commits intoerigontech:mainfrom
sashaodessa wants to merge 5 commits intoerigontech:mainfrom
Conversation
sashaodessa
requested review from
AskAlexSharov,
Giulio2002,
domiwei and
sudeepdino008
as code owners
Collaborator
|
@Giulio2002 CR plz |
Collaborator
|
@domiwei CR plz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove an extra copy of
StateEventspayload when writing state events into the ETL collector.etl.Collectoralready copiesk/vinto its internal buffer. Callingevents.CopyBytes()beforehand duplicated the same byte slice, adding avoidable allocations/GC work on a hot path.