add HistoryKeyTxNumRange and MultisetKV#19081
Merged
AskAlexSharov merged 10 commits intomainfrom Feb 14, 2026
Merged
Conversation
f2cca4e to
352c3b9
Compare
AskAlexSharov
approved these changes
Feb 13, 2026
Collaborator
|
I like the idea to not touch .v files |
AskAlexSharov
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
some tools I need for commitment history regen: #19016
commitment history regen needs: "find all acct/storage touches that happened in block x", then do
ComputeCommitment.HistoryRangeis what we need, but using it is slow:HistoryRangefor each block..which leads to full scan of the ef file. Turns out to be really slow to do.HistoryRange/Uniondoes de-duplication of value..so if we query for 2 blocks and both have a common key, only one gets reported. So block ranges can't be queried (also you cannot identify "which" block the key is touched in).HistoryKeyTxNumRange: solves both problems, it returns stream of<key, txNum>, and so can be queried across multiple blocks (batch fetch). Then we can bucket the touched keys into blocks (since we know txNum). It also doesn't do any de-duplication.MultiSetKV-- is similarly needed for because we need to combine the files data and db data in a non-duplicated manner.