Skip to content

count trie metrics for logs#19087

Open
awskii wants to merge 5 commits intomainfrom
trie-fix-log
Open

count trie metrics for logs#19087
awskii wants to merge 5 commits intomainfrom
trie-fix-log

Conversation

@awskii
Copy link
Member

@awskii awskii commented Feb 10, 2026

This fixes accounting of account and storage nodes during commitment processing, regardless if metrics collection enabled or not - values still in the log like

[applying step 2105][agg] computing trie progress=1.24M/1.67M akeys=0 skeys=0 rdb=0 rda=0 rds=0 wrb=13.95M fld=0 pdur=0s fdur=0s ufdur=0s alloc=12.8GB sys=27.5GB

@taratorio
Copy link
Member

taratorio commented Feb 10, 2026

this used to work fine but has been broken by #18902

it looks like it has disabled the collectCommitmentMetrics here https://github.com/erigontech/erigon/pull/18902/changes#diff-767b2481bde1c3a9e683db9f7cb9c869e5d3a82dc4c4cfd839ae2d3052e71fa2L80

@taratorio taratorio requested review from Giulio2002 and removed request for taratorio February 10, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants