Conversation
lupin012
force-pushed
the
align_mgt_pendingBlock
branch
from
432a2b9 to
4f4b8cd
Compare
AskAlexSharov
approved these changes
Feb 24, 2026
…torageAt Remove early error returns for pending block number in GetBalance, GetCode and GetStorageAt. rpchelper.GetBlockNumber already handles PendingBlockNumber gracefully by falling back to the latest committed block when no pending block is available, so the explicit error was unnecessary and broke callers like bind.transact (PendingCodeAt) used during contract deployment in tests such as TestShutterBlockBuilding. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sudeepdino008
pushed a commit
that referenced
this pull request
Mar 4, 2026
Align pending block behavior to be as close to Geth as possible --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
sudeepdino008
pushed a commit
that referenced
this pull request
Mar 4, 2026
Align pending block behavior to be as close to Geth as possible --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align pending block behavior to be as close to Geth as possible