skip in-mem history accumulation in sd for offline execution#19433
Open
sudeepdino008 wants to merge 7 commits intomainfrom
Open
skip in-mem history accumulation in sd for offline execution#19433sudeepdino008 wants to merge 7 commits intomainfrom
sudeepdino008 wants to merge 7 commits intomainfrom
Conversation
sudeepdino008
changed the title
sudeepdino008
requested review from
AskAlexSharov and
Giulio2002
as code owners
AskAlexSharov
requested changes
Feb 24, 2026
| } | ||
|
|
||
| func (sd *TemporalMemBatch) GetAsOf(domain kv.Domain, key []byte, ts uint64) (v []byte, ok bool, err error) { | ||
| if !sd.inMemHistoryReads { |
Collaborator
There was a problem hiding this comment.
- I guess
GetAsOfused byparallel exec@mh0lt ? - also if you drop old updates i guess you will get invalid state after flush SD to db? (i don't know)
Member
Author
There was a problem hiding this comment.
i think it's only used for rpc (#18575)
`also if you drop old updates i guess you will get invalid state after flush SD to db?``
- no we only use this data for rpc (GEtAsOf -- to provide read since now we collect updates temporalmembatch rather than commit tx). Flush SD to db ignores these old updates.
Contributor
There was a problem hiding this comment.
You only need the in memory reads during exec and rpc processing. These are cleared on flush, but they are also in the ETL queue so after flush the DB will reflect the previous in memory state.
mh0lt
approved these changes
Mar 4, 2026
| } | ||
|
|
||
| func (sd *TemporalMemBatch) GetAsOf(domain kv.Domain, key []byte, ts uint64) (v []byte, ok bool, err error) { | ||
| if !sd.inMemHistoryReads { |
Contributor
There was a problem hiding this comment.
You only need the in memory reads during exec and rpc processing. These are cleared on flush, but they are also in the ETL queue so after flush the DB will reflect the previous in memory state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stage_execorrebuild commitmentfills up faster because sd stores history now..