Open
Conversation
…actor - Track selfDestructedAt access index so balance writes from later txns are not incorrectly skipped in BAL computation - Fix net-zero storage write detection in BAL - Extract BlockAssembler from builderstages/exec.go into exec package - Add merge.NewFaker and Prague pre-deploy support in exec module tester - Fix EIP-7702 committed flag for BAL tracking in state_object - Integrate versionedStateReader and parallel exec determinism fixes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reorder AccountPath enum so SelfDestructPath precedes BalancePath, ensuring updateWrite always sets the selfDestructed flag before evaluating balance skip logic. Add sortVersionedWrites to AsBlockAccessList to guarantee deterministic write processing order regardless of Go map iteration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mh0lt
requested review from
AskAlexSharov,
Giulio2002 and
yperbasis
as code owners
mh0lt
requested review from
shohamc1,
taratorio and
yperbasis
and removed request for
AskAlexSharov,
Giulio2002,
shohamc1,
taratorio and
yperbasis
…nfigurationV1 - Only set BlockAccessListHash on header in builder finish stage for Amsterdam+ chains. Pre-Amsterdam chains with ExperimentalBAL compute the BAL for validation but must not embed it in the header (RLP positional encoding mismatch causes decode failures). - Restore engine_exchangeTransitionConfigurationV1 method that was removed in commit 17e9b48. Hive engine-auth tests rely on this method to verify JWT authentication. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR reinstates the BlockAssembler and the move of BAL processing to the versionedio code rather than as an auxiliary set of functions in the sync process.
The main advantage of this change is that it consolidates behaviour which makes agent understanding more focussed and makes the bal code re-usable in tests. This makes the codebase more streamlined avoids breaks and confusion in test analysis.
It contains fixes merged by the claude agent from #19434 as it has yet to be merged. And #19525.
This should not be merged before those PR's are merged and thier changes integrated here.