Draft
Conversation
- Add pure recsplit() function independent of RecSplit class - Extract recsplitScratch for shared configuration and buffers - Add bucketResult pooling via package-level sync.Pool - Unify sequential and parallel code paths (without workers) - Improve code organization and testability This refactoring improves code quality and enables better separation of concerns without the parallelization infrastructure. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
…ariance The pre-computed golombRice table was sized exactly to bucketSize, but in practice hash distributions can cause individual buckets to occasionally exceed the target size. Add 10% buffer to account for this variance. This fixes the 'index out of range' panic when processing buckets with uneven hash distributions.
Instead of trying to pre-compute with a fixed percentage, pre-populate with a 50% safety margin and let golombParam extend naturally if needed. This ensures we handle various hash distributions without index bounds errors. Fixes TestGCReadAfterRemoveFile and other tests that use RecSplit with different bucket size configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.