Fix CI disk cleanup logic and remove redundancy#19546
Open
lmorett1 wants to merge 1 commit intoerigontech:mainfrom
Open
Fix CI disk cleanup logic and remove redundancy#19546lmorett1 wants to merge 1 commit intoerigontech:mainfrom
lmorett1 wants to merge 1 commit intoerigontech:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues with the disk space cleanup logic in GitHub Actions workflows:
test-all-erigon.yml: Reverts the removal ofif: runner.os == 'Linux'from the "Cleanup space on Linux runner" step (introduced in all-tests: clean macos image #19490). The targeted directories (/opt/az,/usr/share/dotnet, etc.) are specific to GitHub's Ubuntu runner images and do not exist on macOS runners, making execution on macOS a misleading no-op.ci.yml: Removes an exact duplicate of the space cleanup step that was mistakenly running both before and after checkout.