Skip to content

optimize slice allocation in shutter crypto #19562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EthGiveawa375 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

optimize slice allocation in shutter crypto #19562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions txnprovider/shutter/internal/crypto/hash.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,16 @@ func keccak256(ds ...[]byte) []byte {
}

func hashWithPrefix(p byte, b []byte) []byte {
return keccak256(append([]byte{p}, b...))
buf := make([]byte, 1+len(b))
buf[0] = p
copy(buf[1:], b)
return keccak256(buf)
}

func Hash1(b []byte) *blst.P1Affine {
bWithPrefix := append([]byte{1}, b...)
bWithPrefix := make([]byte, 1+len(b))
bWithPrefix[0] = 1
copy(bWithPrefix[1:], b)
p := blst.HashToG1(bWithPrefix, []byte(HashToG1DST))
return p.ToAffine()
}
Expand Down
23 changes: 23 additions & 0 deletions txnprovider/shutter/internal/crypto/helpers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,26 @@ func EnsureGobable(t *testing.T, src, dst any) {
require.NoError(t, err)
assert.Equal(t, src, dst)
}

var globalBuf []byte

func BenchmarkAppend(b *testing.B) {
data := make([]byte, 32)
p := byte(1)
b.ResetTimer()
for i := 0; i < b.N; i++ {
globalBuf = append([]byte{p}, data...)
}
}

func BenchmarkMakeCopy(b *testing.B) {
data := make([]byte, 32)
p := byte(1)
b.ResetTimer()
for i := 0; i < b.N; i++ {
buf := make([]byte, 1+len(data))
buf[0] = p
copy(buf[1:], data)
globalBuf = buf
}
}
Loading