qa-tests: change RPC Integration Latest test trigger#19563
Open
mriccobene wants to merge 2 commits intomainfrom
Open
qa-tests: change RPC Integration Latest test trigger#19563mriccobene wants to merge 2 commits intomainfrom
mriccobene wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the QA RPC Integration “Latest” GitHub Actions workflow trigger strategy to reduce signal noise from a test that currently doesn’t reliably reach tip quickly when starting from a synced DB.
Changes:
- Add a scheduled run and restrict push-based runs to
release/3.*branches. - Remove
pull_requesttriggers formain. - Increase
TOTAL_TIME_SECONDSfrom 900s to 1800s for tip-chasing.
Comments suppressed due to low confidence (1)
.github/workflows/qa-rpc-integration-tests-latest.yml:33
- This PR also increases
TOTAL_TIME_SECONDSfrom 900s to 1800s, but the PR description only mentions changing the trigger conditions. Please either document this runtime increase in the PR description (or in a comment near the variable) or split it into a separate change so it’s clear why the timeout is being adjusted.
ERIGON_QA_PATH: /home/qarunner/erigon-qa
TOTAL_TIME_SECONDS: 1800 # 30 minutes
REFERENCE_SYSTEM_HOST_ADDRESS: 157.180.55.78:8545
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test requires that, when starting Erigon from a synced DB, it reach the tip within a few minutes.
This does not seem to be true. So, temporarily, we change the test trigger: