Skip to content

qa-tests: change RPC Integration Latest test trigger#19563

Merged
Giulio2002 merged 2 commits intomainfrom
qa-tests/reschedule_rpc_integration_latest
Mar 3, 2026
Merged

qa-tests: change RPC Integration Latest test trigger#19563
Giulio2002 merged 2 commits intomainfrom
qa-tests/reschedule_rpc_integration_latest

Conversation

@mriccobene
Copy link
Member

This test requires that, when starting Erigon from a synced DB, it reach the tip within a few minutes.
This does not seem to be true. So, temporarily, we change the test trigger:

  • run nightly in main,
  • run on every push in release

Copilot AI review requested due to automatic review settings March 2, 2026 09:33
@mriccobene mriccobene requested review from Giulio2002 and canepat March 2, 2026 09:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the QA RPC Integration “Latest” GitHub Actions workflow trigger strategy to reduce signal noise from a test that currently doesn’t reliably reach tip quickly when starting from a synced DB.

Changes:

  • Add a scheduled run and restrict push-based runs to release/3.* branches.
  • Remove pull_request triggers for main.
  • Increase TOTAL_TIME_SECONDS from 900s to 1800s for tip-chasing.
Comments suppressed due to low confidence (1)

.github/workflows/qa-rpc-integration-tests-latest.yml:33

  • This PR also increases TOTAL_TIME_SECONDS from 900s to 1800s, but the PR description only mentions changing the trigger conditions. Please either document this runtime increase in the PR description (or in a comment near the variable) or split it into a separate change so it’s clear why the timeout is being adjusted.
      ERIGON_QA_PATH: /home/qarunner/erigon-qa
      TOTAL_TIME_SECONDS: 1800 # 30 minutes
      REFERENCE_SYSTEM_HOST_ADDRESS: 157.180.55.78:8545

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@Giulio2002 Giulio2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Pippi

@Giulio2002 Giulio2002 merged commit 8d4b28d into main Mar 3, 2026
25 of 26 checks passed
@Giulio2002 Giulio2002 deleted the qa-tests/reschedule_rpc_integration_latest branch March 3, 2026 16:31
sudeepdino008 pushed a commit that referenced this pull request Mar 4, 2026
This test requires that, when starting Erigon from a synced DB, it reach
the tip within a few minutes.
This does not seem to be true. So, temporarily, we change the test
trigger:
- run nightly in main, 
- run on every push in release
sudeepdino008 pushed a commit that referenced this pull request Mar 4, 2026
This test requires that, when starting Erigon from a synced DB, it reach
the tip within a few minutes.
This does not seem to be true. So, temporarily, we change the test
trigger:
- run nightly in main, 
- run on every push in release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants