Skip to content

qa-tests: use a specific version of the prebuilt db in RPC tests #19565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mriccobene wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

qa-tests: use a specific version of the prebuilt db in RPC tests #19565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/qa-rpc-integration-tests-gnosis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
cancel-in-progress: true
runs-on: [ self-hosted, qa, Gnosis, rpc-integration ]
env:
ERIGON_REFERENCE_DATA_DIR: /opt/erigon-versions/gnosis-reference-version/datadir
ERIGON_REFERENCE_DATA_DIR: /opt/erigon-versions/gnosis-reference-version-3.4/datadir
ERIGON_TESTBED_AREA: /opt/erigon-testbed
ERIGON_QA_PATH: /home/qarunner/erigon-qa
ERIGON_ASSERT: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/qa-rpc-integration-tests-latest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
cancel-in-progress: true
runs-on: [ self-hosted, qa, Ethereum, rpc-latest-erigon ]
env:
ERIGON_REFERENCE_DATA_DIR: /opt/erigon-versions/reference-version/datadir
ERIGON_REFERENCE_DATA_DIR: /opt/erigon-versions/reference-version-3.4/datadir
ERIGON_TESTBED_DATA_DIR: /opt/erigon-testbed/datadir
ERIGON_QA_PATH: /home/qarunner/erigon-qa
TOTAL_TIME_SECONDS: 900 # 15 minutes
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/qa-rpc-integration-tests-remote.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
cancel-in-progress: true
runs-on: [ self-hosted, qa, Ethereum, rpc-integration-commitment ]
env:
ERIGON_REFERENCE_DATA_DIR: /opt/erigon-versions/reference-version/datadir
ERIGON_REFERENCE_DATA_DIR: /opt/erigon-versions/reference-version-3.4/datadir
ERIGON_TESTBED_AREA: /opt/erigon-testbed
ERIGON_QA_PATH: /home/qarunner/erigon-qa
ERIGON_ASSERT: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/qa-rpc-integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
cancel-in-progress: true
runs-on: [ self-hosted, qa, Ethereum, rpc-integration-commitment ]
env:
ERIGON_REFERENCE_DATA_DIR: /opt/erigon-versions/reference-version/datadir
ERIGON_REFERENCE_DATA_DIR: /opt/erigon-versions/reference-version-3.4/datadir
ERIGON_TESTBED_AREA: /opt/erigon-testbed
ERIGON_QA_PATH: /home/qarunner/erigon-qa
ERIGON_ASSERT: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/qa-rpc-performance-comparison-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:
RUN_ID: ${{ needs.setup.outputs.run_id }}
NETWORK: ${{ needs.setup.outputs.network }}
ERIGON_REFERENCE_DIR: /opt/erigon-versions/reference-version
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERIGON_REFERENCE_DATA_DIR is now versioned, but ERIGON_REFERENCE_DIR remains unversioned and is later used to read production.ini for db_version. This can desync the metadata you record from the actual reference datadir under test; consider reading production.ini relative to ERIGON_REFERENCE_DATA_DIR (../production.ini) or versioning ERIGON_REFERENCE_DIR together with the datadir selection.

Suggested change
ERIGON_REFERENCE_DIR: /opt/erigon-versions/reference-version
ERIGON_REFERENCE_DIR: /opt/erigon-versions/reference-version-3.4

Copilot uses AI. Check for mistakes.
ERIGON_REFERENCE_DATA_DIR: /opt/erigon-versions/reference-version/datadir
ERIGON_REFERENCE_DATA_DIR: /opt/erigon-versions/reference-version-3.4/datadir
ERIGON_TESTBED_DATA_DIR: /opt/erigon-testbed/datadir
TOTAL_TIME_SECONDS: 1200 # 20 minutes
Comment on lines 97 to 102
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERIGON_REFERENCE_DATA_DIR is hardcoded to a release-specific DB path, but this workflow runs on schedule from the default branch as well. To achieve the PR goal of different DBs on main vs release, select the reference datadir based on github.ref/base_ref (e.g., keep /opt/erigon-versions/reference-version/datadir for main and use the versioned directory only for release/*).

Copilot uses AI. Check for mistakes.
GETH_INSTALL_DIR: /opt/go-ethereum
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/qa-rpc-performance-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
RUN_ID: ${{ needs.setup.outputs.run_id }}
NETWORK: ${{ needs.setup.outputs.network }}
ERIGON_REFERENCE_DIR: /opt/erigon-versions/reference-version
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERIGON_REFERENCE_DATA_DIR now points at a versioned DB, but ERIGON_REFERENCE_DIR is still the unversioned path and is later used to read production.ini for db_version. This can make the reported DB version (and potentially other reference metadata) inconsistent with the actual datadir being tested; consider deriving production.ini from ERIGON_REFERENCE_DATA_DIR (../production.ini) or versioning ERIGON_REFERENCE_DIR in lockstep. Also note this workflow runs on schedule from the default branch, so hardcoding "-3.4" here will force main’s scheduled runs to use the release DB unless you branch-select the path via github.ref/base_ref.

Suggested change
ERIGON_REFERENCE_DIR: /opt/erigon-versions/reference-version
ERIGON_REFERENCE_DIR: /opt/erigon-versions/reference-version-3.4

Copilot uses AI. Check for mistakes.
ERIGON_REFERENCE_DATA_DIR: /opt/erigon-versions/reference-version/datadir
ERIGON_REFERENCE_DATA_DIR: /opt/erigon-versions/reference-version-3.4/datadir
ERIGON_TESTBED_AREA: /opt/erigon-testbed
ERIGON_QA_PATH: /home/qarunner/erigon-qa
GETH_INSTALL_DIR: /opt/go-ethereum
Expand Down
Loading